jusax23/actions-test
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fixed bug where public rooms weren't filtered correctly

Browse source 
This was caused by doNetworkRequest
introduced in Commit 5d333522a5 (Simplified network requests & snackbars, 2023-03-23),
as it ran asynchronously and thus the blacklist wasn't filled in time.
This commit is contained in:
Jakob Meier 2023-03-31 21:54:45 +02:00
parent 99f0ed3558
commit a40e3af3e5
No known key found for this signature in database
GPG key ID: 66BDC7E6A01A6152
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/screens/room/join.dart
View file

@ -36,7 +36,7 @@ class _JoinRoomPageState extends State {
// try to fetch a list of rooms the user is a member of // try to fetch a list of rooms the user is a member of
// use an empty blacklist when request is not successful // use an empty blacklist when request is not successful
final List<Room> blacklist = []; final List<Room> blacklist = [];
doNetworkRequest(sm, await doNetworkRequest(sm,
req: () => postWithCreadentials( req: () => postWithCreadentials(
path: 'listRooms', path: 'listRooms',
credentials: user, credentials: user,
@ -62,7 +62,7 @@ class _JoinRoomPageState extends State {
// only add room to list, // only add room to list,
// if not on blacklist // if not on blacklist
for (Room r in blacklist) { for (Room r in blacklist) {
if (r.compareTo(room) == 0) { if (r == room) {
// server on white list // server on white list
// move to next iteration on outer for loop // move to next iteration on outer for loop
continue processor; continue processor;